-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphEdit's minimap can be resized to be wider than the view. #47189
Comments
I'm investigating on this issue. I think we should also resize the minimap when the graphEdit is resized to a smaller size than minimap. |
Yes, I was aware of this when I implemented it. However, logic here is that user has to do this on purpose, and at a reasonable size this does not happen by itself to cause the user discomfort. And if you resize the editor itself to be smaller than the minimap, you can likely extend it back to a normal size and make minimap smaller beforehand. In other words, I don't see a reasonable limit that we can implement, and it's up to the user. Though maybe some way to reset it to its default size can be introduced. |
Minimap size couldn't be resized back after been resized bigger than GraphEdit cause the grabber was out of GraphEdit. This commit prevents resizing minimap bigger than GraphEdit and fix this issue.
OK, resizing the minimap when GraphEdit is resized is not so important. And could even be annoying when we just resizing the editor inspector or tree panel for a short time (we need to re-enlarge the minimap after that...) On the other hand, I think that preventing resizing the minimap larger than the graphedit need a fix. |
Sure, we can prevent it a bit. But even if you stop the resize at the GraphEdit's size user can still resize the GraphEdit after that to be smaller than the minimap, producing the same state. Which is why I deemed this unimportant initially. But I guess you can prevent weird accidents this way at least. |
As you said, if the user set a smaller graphEdit manually, he can still set it back larger by hand. (You convince me that my proposal was useless). |
…-than-GraphEdit Prevent resizing minimap bigger than GraphEdit (Fix #47189)
Minimap size couldn't be resized back after been resized bigger than GraphEdit cause the grabber was out of GraphEdit. This commit prevents resizing minimap bigger than GraphEdit and fix this issue. (cherry picked from commit 045f55e)
Minimap size couldn't be resized back after been resized bigger than GraphEdit cause the grabber was out of GraphEdit. This commit prevents resizing minimap bigger than GraphEdit and fix this issue. (cherry picked from commit 045f55e)
Minimap size couldn't be resized back after been resized bigger than GraphEdit cause the grabber was out of GraphEdit. This commit prevents resizing minimap bigger than GraphEdit and fix this issue. (cherry picked from commit 045f55e)
Godot version: master (62e134a) and 3.x (f50c806)
OS/device including version: not graphics-related
Issue description: The minimap of
GraphEdit
can be resized to be wider than the view, and could not be resized back because the resize handle on the top left corner of the minimap is outside the view.Steps to reproduce:
AnimationTree
node and create anAnimationNodeBlendTree
as root.Minimal reproduction project: Not project specific, create an empty VisualScript is faster.
The text was updated successfully, but these errors were encountered: