Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.2.4 beta 2] Bug with the focus remaining on the main menu #43695

Closed
dalexeev opened this issue Nov 19, 2020 · 4 comments · Fixed by #43977
Closed

[3.2.4 beta 2] Bug with the focus remaining on the main menu #43695

dalexeev opened this issue Nov 19, 2020 · 4 comments · Fixed by #43977
Assignees
@akien-mga
Labels
bug confirmed regression topic:editor
Milestone
3.2

Comments

@dalexeev
Copy link
Member

Godot version:
3.2.3 - OK
3.2.4.beta2 - Bug

OS/device including version:
Kubuntu 20.10

Issue description:
3.2.3:
3.2.3

3.2.4.beta2:
3.2.4.beta2

Steps to reproduce:
See above.

Minimal reproduction project:
—
@akien-mga akien-mga added this to the 3.2 milestone Nov 19, 2020
@akien-mga
Copy link
Member

Confirmed, the issue also happens with 3.2.4.beta1, so the regression happened before beta1 (i.e. before 2e073ec).

@akien-mga
Copy link
Member

That seems to be a regression from #41577, CC @FIF15. We might have overlooked something in that PR.

@akien-mga akien-mga self-assigned this Nov 19, 2020
@FIF15
Copy link
Contributor

FIF15 commented Nov 30, 2020

That seems to be a regression from #41577, CC @FIF15. We might have overlooked something in that PR.

I've confirmed that the removal of set_enabled_focus_mode(FOCUS_NONE); from #41577 is the direct reason for this bug. We removed it because the default focus mode of Controls is FOCUS_NONE, however, it is set to FOCUS_ALL in the BaseButton's constructor. Therefore, the removal changed the default behavior of MenuButton and LinkButton. Also, this shall happen on the master. I would make PR for both 3.2 and master to fix this.

FIF15 added a commit to FIF15/godot that referenced this issue Nov 30, 2020
@FIF15
fix godotengine#43695 by revert part of godotengine#41577
f07fb4e 
Restore the default focus mode for MenuButton and LinkButton,
since it is different from the default of BaseButton.
@FIF15 FIF15 mentioned this issue Nov 30, 2020
Merged
FIF15 added a commit to FIF15/godot that referenced this issue Nov 30, 2020
@FIF15
fix godotengine#43695 by revert part of godotengine#41576
96fb9ee 
Note that godotengine#42109 already reverted the change of MenuButton,
and actually fixed godotengine#43695.
As a result, this commit only reverts the change to LinkButton,
in order to prevent unpredictable consequences.
@FIF15 FIF15 mentioned this issue Nov 30, 2020
Merged
akien-mga added a commit that referenced this issue Nov 30, 2020
@akien-mga
Merge pull request #43974 from FIF15/restore-default-focus-mode
848b9e7 
fix #43695 on 3.2 by revert part of  #41577
akien-mga added a commit that referenced this issue Nov 30, 2020
@akien-mga
Merge pull request #43977 from FIF15/restore-default-focus-mode-on-ma…
2c6e6e9 
…ster

fix #43695 on master by revert part of #41576
@akien-mga
Copy link
Member

Fixed by #43977 and #43974.

HEAVYPOLY pushed a commit to HEAVYPOLY/godot that referenced this issue Dec 14, 2020
@FIF15 @HEAVYPOLY
fix godotengine#43695 by revert part of godotengine#41577
1fc0da4 
Restore the default focus mode for MenuButton and LinkButton,
since it is different from the default of BaseButton.
@yjh0502 yjh0502 mentioned this issue Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akien-mga akien-mga

Labels
bug confirmed regression topic:editor
Projects
None yet
Milestone
3.2
3 participants
@akien-mga @FIF15 @dalexeev