Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GridMap remains visible if parent is set to not visible #41374

Closed
tcoxon opened this issue Aug 19, 2020 · 3 comments · Fixed by #42848
Closed

GridMap remains visible if parent is set to not visible #41374

tcoxon opened this issue Aug 19, 2020 · 3 comments · Fixed by #42848
Labels
bug confirmed topic:core
Milestone
4.0

Comments

@tcoxon
Copy link
Contributor

tcoxon commented Aug 19, 2020

Godot version:
3.2.2

OS/device including version:
Ubuntu Linux 16.04, 64-bit
GeForce GTX 970 with NVIDIA 384.130 driver
GLES3 backend

Issue description:
GridMaps remain visible in the editor and at runtime while parent spatial nodes are set to invisible.

Steps to reproduce:

  1. Create a GridMap node in a 3D scene
  2. Set the scene root to invisible
  3. Notice the GridMap remains visible while the rest of the scene is hidden.

Minimal reproduction project:
GridMap-Visible.zip

If you run the project you can press space to toggle the visibility of the scene. Note that the DirectionalLight and the Sprite3D correctly hide while the GridMap remains on the screen.
@Calinou
Copy link
Member

Calinou commented Aug 19, 2020 •
edited
Loading

This was reported a long time ago in #907 (closed in 2017), but it seems the bug appeared again according to #10418 (comment).

@Blizbor
Copy link

Blizbor commented Aug 30, 2020

Hi,

I just entered github to report same issue but found that existing report.
I can confirm problem exist - same version (3.2.2 official binaries) on Windows 10, backend GLES3.

Anyway - amazing work guys, I like GODOT so much.

Cheers,

@akien-mga akien-mga added this to the 4.0 milestone Oct 24, 2020
akien-mga added a commit that referenced this issue Oct 24, 2020
@akien-mga
Merge pull request #42848 from Tadaboody/bugfix/gridmap_visibility
d3dd8fb 
Setting visibility on GridMaps parent now works. Closes #41374.
@akien-mga akien-mga mentioned this issue Oct 24, 2020
Merged
akien-mga pushed a commit to akien-mga/godot that referenced this issue Oct 28, 2020
@Tadaboody @akien-mga
Setting visibility on GridMap now works. Closes godotengine#41374.
3e4816e 
Continuing the work from f43a0ef,
It seems the maps visibility was not actually set and a flase value was propogated to the meshes
Trying to set the maps visibility directly (Using `set_visibility` causes the map to no longer to recieve visibility notifications, instead this approach was chosen

(cherry picked from commit fe52c6b)
@jamesdkay
Copy link

Does anyone know if this issue is related to #40245, and if this solution will resolve that issue too?

@jamesdkay jamesdkay mentioned this issue Feb 2, 2021
Open
@yjh0502 yjh0502 mentioned this issue Aug 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed topic:core
Projects
None yet
Milestone
4.0
5 participants
@tcoxon @Calinou @akien-mga @Blizbor @jamesdkay