Fullscreen setting is broken

[Anutrix]

Godot version:
master 321ce4d

OS/device including version:
Windows 10 Pro

Issue description:
Setting the fullscreen option just makes the window of the game borderless. The size remains same and doesn't cover the whole screen.
Fullscreen unchecked:

Fullscreen checked:

Steps to reproduce:

1. Check fullscreen option in Project Settings.
2. Run the project.

Minimal reproduction project:
Any

[Anutrix]

Before:
After Shift+F11:

The issue is that input still works and it works on the window behind it. Can wreak havoc. Should be high-risk issue.

[KoBeWi]

For some reason this still exists in 9e34ba4 (although the PR did fix it, so it just broke again)

[Anutrix]

Anyone worked/working on this?
It can still be reproduced in latest master 41f6676.

[DimitriyPS]

@Anutrix Do you have multiple screens? What screen resolution?

[Anutrix]

@Anutrix Do you have multiple screens? What screen resolution?

Sorry about the super long delay, but no. I only have one display.

Haven't checked if it's reproducible in recent builds.

[KoBeWi]

I checked in f7ca732. fullscreen makes window borderless and borderless makes the window fullscreen. Looks like the flags are swapped for some reason.

[Calinou]

I checked in f7ca732. fullscreen makes window borderless and borderless makes the window fullscreen. Looks like the flags are swapped for some reason.

Good catch 🙂

See also my suggestion in godotengine/godot-proposals#4413, which could resolve this issue at the same time.

[KoBeWi]

I tried to find out what causes the issue, but no luck. It's probably something in Window initialization code as setting fullscreen/borderless after initialization works fine.

Also it's not that the flags are swapped. Fullscreen makes the window borderless and it's correct, but the bug is that you need both fullscreen and borderless enabled for the window to be fullscreen at start.

[TokisanGames]

alpha12, two 1920x1080 screens, win10/64 gtx1060

• 1024x600, resizable => 1024x600 resizable
• 1024x600, borderless => 1024x600 borderless
• 1024x600, full screen => 1920x1080 moveable window w/ title !!!
• 1024x600, resizable, full screen => 1024x600 borderless window !!!
• 1024x600, borderless, full screen => 1920x1080 full screen borderless window
• 1024x600, borderless, resizable, full screen => 1920x1080 full screen borderless window

There are two permutations that are wrong. Maybe all that is needed is for fullscreen to imply borderless, as it did in gd3. That could be a one line fix in the class that reads the options.

[bruvzg]

On Windows, this should be already fixed by #63194 (merged after alpha 12).

[KoBeWi]

Can confirm it's fixed.

Although I noticed that when you have both borderless and fullscreen enabled, it causes a weird 1px outline at the borders. But that's another issue I guess.