Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F2 in Input Map and Editor Shortcuts dialog have space between F and 2 #33305

Closed
KoBeWi opened this issue Nov 3, 2019 · 1 comment · Fixed by #33335
Closed

F2 in Input Map and Editor Shortcuts dialog have space between F and 2 #33305

KoBeWi opened this issue Nov 3, 2019 · 1 comment · Fixed by #33335
Labels
bug topic:editor
Milestone
3.2

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Nov 3, 2019

Godot version:
3.2 beta3

Issue description:
image

Ofc happens to other Fs too. Displays properly in Editor Shortcut list, but same problem on Input Actions list.
image
image
@Calinou
Copy link
Member

Calinou commented Nov 3, 2019 •
edited
Loading

This is presumably because the String::capitalize() function is used behind the scenes, which separates letters from numbers.

Key names are defined in core/os/keyboard.cpp, but the function keys' names look fine in that file:

https://github.com/godotengine/godot/blob/master/core/os/keyboard.cpp

We could also improve the key names to be more natural while we're at it 🙂

Calinou added a commit to Calinou/godot that referenced this issue Nov 4, 2019
@Calinou
Fix key names being wrongly capitalized in the input map editor
b14e391 
This also fixes the prompt in the editor shortcuts dialog
while removing duplicated code.

This closes godotengine#33305.
@Calinou Calinou mentioned this issue Nov 4, 2019
Merged
@akien-mga akien-mga added this to the 3.2 milestone Nov 4, 2019
victordomiciano pushed a commit to JavaryGames/godot that referenced this issue Dec 3, 2019
@Calinou @victordomiciano
Fix key names being wrongly capitalized in the input map editor
f15b1eb 
This also fixes the prompt in the editor shortcuts dialog
while removing duplicated code.

This closes godotengine#33305.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Fix key names being wrongly capitalized in the input map editor Calinou/godot
3 participants
@Calinou @KoBeWi @akien-mga