-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Audio bottom panel goes under the taskbar on small displays (also SpriteFrames editor, shader editor, etc.) #26835
Comments
Working on it :) |
I was looking at it with samH, we weren't able to recreate it on a windows machine but we were able to recreate on a mac. Could you provide additional details on how you produced it? |
I'm almost sure that I saw same issue maybe half year ago, but I can't find. To reproduce this you need to have small height of screen.
Video: https://streamable.com/cmwkt I don't really think that is really a bug. When minimum size of Godot docks are greater than current available space on screen, then Godot try to resize window or just hide part of self |
After running rc3, the bug gone in rc1 or beta. I did the folowing the bug reproduced in rc3:
the bug will reproduce after running an older version |
I can confirm this on commit 580b0c6. Small editorLarge editorTo solve this, we could decrease the minimum size of the Audio tab (and allow scrolling inside if it's not tall enough to display the volume sliders). |
This is also the case sometimes with Animations and other huge tabs not just Audio. |
Can anyone still reproduce this bug in Godot 3.2.3 or any later release? |
Why not calculate panel sizes from the edges inwards? I think having a separate minimum and default size (#26392 (comment)) would help combat this issue. |
@jiqz Unfortunately, Godot's GUI system does not have a way to define separate minimum and default sizes for Controls under containers. It's not something that can be implemented quickly. What we can do is use a lower minimum height for the Audio panel and downsize (or even hide) the VU meters if the Audio tab isn't tall enough. This will make the Audio panel more usable on small displays. |
Still reproducible in 4.0 beta 5. The same happens with the shader editor, and the sprite frames editor (#16164). Basically any two editor plugins stacked vertically with a combined minimum height higher than the window size will overflow the available space. |
Can we make lines of icons in the editor use FlowContainer to avoid this issue? |
There is a PR for the toolbar in the SpriteFrame editor (already merged, #77034). But the original issue here seems to be about height, not width? |
Rather than making it scrollable (which may be difficult to implement), I'd display ellipses for button texts to shorten them if there isn't enough width to display all of them. We could also conditionally replace all button texts with short variants if there isn't enough width:
This would require translators to come up with short variants though. |
This problem is still present in 4.3. |
Godot version:
v3.1.rc1
OS/device including version:
windows 10 x64
Issue description:
When click on "Audio" tab, the bottom side of godot goes under the taskbar, until toggle full screen and change to other tab (output, debugger, ..)
The text was updated successfully, but these errors were encountered: