Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Audio bottom panel goes under the taskbar on small displays (also SpriteFrames editor, shader editor, etc.) #26835

Open
sami8github opened this issue Mar 9, 2019 · 15 comments

Comments

@sami8github
Copy link

Godot version:
v3.1.rc1

OS/device including version:
windows 10 x64

Issue description:
When click on "Audio" tab, the bottom side of godot goes under the taskbar, until toggle full screen and change to other tab (output, debugger, ..)

image

image

@akien-mga akien-mga added this to the 3.2 milestone Mar 9, 2019
@samH-FIT
Copy link
Contributor

Working on it :)

@LightIncorporated
Copy link
Contributor

I was looking at it with samH, we weren't able to recreate it on a windows machine but we were able to recreate on a mac. Could you provide additional details on how you produced it?

@qarmin
Copy link
Contributor

qarmin commented Mar 12, 2019

I'm almost sure that I saw same issue maybe half year ago, but I can't find.

To reproduce this you need to have small height of screen.
Also it is possible to reproduce this bug in similar way(in this case is horizontal but it has same cause):

  1. Change to 2d viewport with opened Output window

  2. Change godot size to smallest as possible

  3. Open script tab and open at bottom Audio tab

  4. (For me only this point is issue) When I change godot back to 2D viewport and Output tab, then Godot still hide some part of editor, even if have a lot of space. Godot reorganize docks only if we manually change it size.

Video: https://streamable.com/cmwkt

I don't really think that is really a bug. When minimum size of Godot docks are greater than current available space on screen, then Godot try to resize window or just hide part of self

@sami8github
Copy link
Author

sami8github commented Mar 13, 2019

After running rc3, the bug gone in rc1 or beta.

I did the folowing the bug reproduced in rc3:

  1. run rc3 (no bug) and close it
  2. run beta9 (no bug) and close it
  3. run rc3 again it will reproduce
  4. close rc3 and run it again (nobug)

the bug will reproduce after running an older version

@Calinou
Copy link
Member

Calinou commented May 17, 2019

I can confirm this on commit 580b0c6.

Small editor

image

Large editor

image

To solve this, we could decrease the minimum size of the Audio tab (and allow scrolling inside if it's not tall enough to display the volume sliders).

@ultimateprogramer
Copy link

This is also the case sometimes with Animations and other huge tabs not just Audio.

@KoBeWi
Copy link
Member

KoBeWi commented Dec 24, 2020

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

@jiqz
Copy link

jiqz commented Jul 10, 2021

Why not calculate panel sizes from the edges inwards? I think having a separate minimum and default size (#26392 (comment)) would help combat this issue.

@Calinou
Copy link
Member

Calinou commented Jul 10, 2021

@jiqz Unfortunately, Godot's GUI system does not have a way to define separate minimum and default sizes for Controls under containers. It's not something that can be implemented quickly.

What we can do is use a lower minimum height for the Audio panel and downsize (or even hide) the VU meters if the Audio tab isn't tall enough. This will make the Audio panel more usable on small displays.

@Calinou Calinou changed the title Audio tab goes under the taskbar The Audio panel goes under the taskbar on small displays Jul 10, 2021
@KoBeWi KoBeWi moved this to To Assess in 4.x Priority Issues May 29, 2022
@KoBeWi KoBeWi moved this from To Assess to Todo in 4.x Priority Issues May 29, 2022
@akien-mga
Copy link
Member

Still reproducible in 4.0 beta 5.

The same happens with the shader editor, and the sprite frames editor (#16164).

Basically any two editor plugins stacked vertically with a combined minimum height higher than the window size will overflow the available space.

@akien-mga akien-mga removed this from the 4.0 milestone Nov 21, 2022
@akien-mga akien-mga changed the title The Audio panel goes under the taskbar on small displays The Audio panel goes under the taskbar on small displays (also SpriteFrames editor, shader editor, etc.) Nov 21, 2022
@winston-yallow
Copy link
Contributor

winston-yallow commented Apr 19, 2023

As a note:
Additionally to the vertical overflow mentioned initially, the overflow also happens horizontally when the screen is 1366px wide and the sprite frames editor is open (screenshot by Ali_Ali on discord). This is still an issue in 4.0.2-stable.

image

@Calinou
Copy link
Member

Calinou commented May 24, 2023

Can we make lines of icons in the editor use FlowContainer to avoid this issue?

@YuriSizov
Copy link
Contributor

Can we make lines of icons in the editor use FlowContainer to avoid this issue?

There is a PR for the toolbar in the SpriteFrame editor (already merged, #77034). But the original issue here seems to be about height, not width?

@Calinou
Copy link
Member

Calinou commented Apr 4, 2024

Rather than making it scrollable (which may be difficult to implement), I'd display ellipses for button texts to shorten them if there isn't enough width to display all of them. We could also conditionally replace all button texts with short variants if there isn't enough width:

Out    Dbg    Search    Audio    Anim    Shader    MSBuild

This would require translators to come up with short variants though.

@Calinou Calinou changed the title The Audio panel goes under the taskbar on small displays (also SpriteFrames editor, shader editor, etc.) The Audio bottom panel goes under the taskbar on small displays (also SpriteFrames editor, shader editor, etc.) Apr 4, 2024
@JekSun97
Copy link
Contributor

This problem is still present in 4.3.
I also ran into a similar problem on a larger monitor using the Tokisan plugin - TokisanGames/Terrain3D#417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests