VisualServer methods are not bound

[Zylann]

Godot 3.0 master a1c08b7

I am porting my heightmap module to GDNative, but I noticed many functions of VisualServer are not available, neither in the C++ bindings, nor in GDScript to begin with. A bunch of functions are available, but not those I need:

instance_create
instance_geometry_set_material_override
instance_set_scenario
instance_set_visible
instance_set_scenario
instance_set_transform
instance_set_base
...

The whole instance API?
They were available in 2.1.4, not in 3.0

[reduz]

Probably forgot to bind them. Feel free to do it.

…

On Jan 19, 2018 7:34 PM, "Marc" ***@***.***> wrote: Godot 3.0 master 131cf2581e05897ecb40ad527a01cd9068c58628 I am porting my heightmap module to GDNative, but I noticed many functions of VisualServer are not available, neither in the C++ bindings, nor in GDScript to begin with. A bunch of functions are available, but not those I need: instance_create instance_geometry_set_material_override instance_set_scenario instance_set_visible instance_set_scenario instance_set_transform instance_set_base ... The whole instance API? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15879>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z2wcwIoZFFIGsEV3l9qb842tThvWHks5tMRhxgaJpZM4RlJDl> .

[Zylann]

Where should I look for those bindings?
Edit: found them

[reduz]

VisualServer::_bind_methods

…

On Jan 19, 2018 7:38 PM, "Marc" ***@***.***> wrote: Where should I look for bindings? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#15879 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z22eOlLvoVZfxA07hAdV2mD2E0R3jks5tMRlqgaJpZM4RlJDl> .

[Zylann]

I noted that some methods are bound twice, like draw, sync, force_draw and force_sync

[Zylann]

Can I add all other missing ones? Multimesh, Immediate, Skeleton, Light, Reflection probe, GI probe, lightmap, particles, camera, environment, scenario

[leonkrause]

I added bindings for some VS functions a while ago. I left comments what's left to do:

godot/servers/visual_server.cpp

Line 1549 in eb9fa02

// TODO: multimesh_*, immediate_*, skeleton_*, light_*, reflection_probe_*, gi_probe_*, particles_*, camera_*

godot/servers/visual_server.cpp

Line 1582 in eb9fa02

// TODO: environment_*, scenario_*, instance_*

About draw and sync, you can remove the bindings missing the force_ prefix, probably just an oversight of mine

[Zylann]

@eska014 why call them "force_*" if the base function isn't call that way though? Also draw and sync were existing in 2.x
I finished binding all the stuff, phew... will take some sleep before I figure out which of these duplicates to remove

[leonkrause]

The force_ prefix makes these functions sound scarier, so users don't touch them unless they know they really need them