Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation csv reimport causes segfault when run from command line #11189

Closed
endragor opened this issue Sep 12, 2017 · 1 comment · Fixed by #11875
Closed

Translation csv reimport causes segfault when run from command line #11189

endragor opened this issue Sep 12, 2017 · 1 comment · Fixed by #11875
Labels
bug topic:editor
Milestone
3.0

Comments

@endragor
Copy link
Contributor

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Godot 3.0 (e8ad604), macOS Sierra 10.12.6

Issue description:
When exporting project from command line, translation.csv reimport causes weird behaviour (export loop followed by segfault) afterwards, as if the memory got corrupted. There is no segfault when reimport is done when you open the project in the editor without immediately exporting.

Steps to reproduce:

git clone -b translation-bug https://github.com/endragor/etc2bug.git translationbug
cd translationbug
godot --export Android test.apk
@akien-mga akien-mga added this to the 3.0 milestone Sep 12, 2017
@endragor
Copy link
Contributor Author

endragor commented Oct 3, 2017

Similar behaviour also occurs under different circumstances, not only after translation reimport, but also when exporting from command line.

endragor added a commit to endragor/godot that referenced this issue Oct 6, 2017
@endragor
Fix command-line export looping infinitely
0cd9993 
EditorProgress calls Main::iteration which calls MessageQueue::flush
which may result in _fs_changed being called again. This fixes the loop
Godot enters in such case.

Fixes godotengine#11189
@endragor endragor mentioned this issue Oct 6, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Fix command-line export looping infinitely endragor/godot
2 participants
@endragor @akien-mga