Skip to content

Commit

Permalink
Merge pull request #12360 from volzhs/ttr-format
Browse files Browse the repository at this point in the history
Fix warning message format for addon plugin

[ci skip]
  • Loading branch information
akien-mga authored Oct 23, 2017
2 parents c529fa6 + 59cc6f2 commit 9f78878
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions editor/editor_node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2670,12 +2670,12 @@ void EditorNode::set_addon_plugin_enabled(const String &p_addon, bool p_enabled)
String addon_path = "res://addons/" + p_addon + "/plugin.cfg";
Error err = cf->load(addon_path);
if (err != OK) {
show_warning(TTR("Unable to enable addon plugin at: '") + addon_path + TTR("' parsing of config failed."));
show_warning(vformat(TTR("Unable to enable addon plugin at: '%s' parsing of config failed."), addon_path));
return;
}

if (!cf->has_section_key("plugin", "script")) {
show_warning(TTR("Unable to find script field for addon plugin at: 'res://addons/") + p_addon + "''.");
show_warning(vformat(TTR("Unable to find script field for addon plugin at: 'res://addons/%s'."), p_addon));
return;
}

Expand All @@ -2685,18 +2685,18 @@ void EditorNode::set_addon_plugin_enabled(const String &p_addon, bool p_enabled)
Ref<Script> script = ResourceLoader::load(path);

if (script.is_null()) {
show_warning(TTR("Unable to load addon script from path: '") + path + "'.");
show_warning(vformat(TTR("Unable to load addon script from path: '%s'."), path));
return;
}

//could check inheritance..
if (String(script->get_instance_base_type()) != "EditorPlugin") {
show_warning(TTR("Unable to load addon script from path: '") + path + "' Base type is not EditorPlugin.");
show_warning(vformat(TTR("Unable to load addon script from path: '%s' Base type is not EditorPlugin."), path));
return;
}

if (!script->is_tool()) {
show_warning(TTR("Unable to load addon script from path: '") + path + "' Script is not in tool mode.");
show_warning(vformat(TTR("Unable to load addon script from path: '%s' Script is not in tool mode."), path));
return;
}

Expand Down

0 comments on commit 9f78878

Please sign in to comment.