FBX Importer Rewrite

Co-authored-by: Gordon MacPherson <[email protected]>
Co-authored-by: Andrea Catania <[email protected]>
Co-authored-by: K. S. Ernest (iFire) Lee <[email protected]>

This is a complete rewrite of the importer. It will give more deterministic behaviour and has been sponsored by IMVU inc, over 1 year has gone into the development of this importer to remove the burden of the FBX SDK.

This was my project for 1 entire year and I really enjoyed the opportunity to add to Godot.

Along the road of implementing fixes we implemented fbx pivots, animations and inheritance type handling, which in most cases works properly.

We have implemented animation and mesh skinning too this should work out of the box, if there are issues let us know.

It's designed so that you can expand this with ease, and fix bugs easily too.

It can import from Autodesk Maya and import into Godot, with pivots.

There are bits we could polish but for now this is good enough.

This was sponsored by IMVU, and a special thanks to everyone who supported this project.

Signed-off-by: Gordon MacPherson <[email protected]>

Additional fixes made before upstreaming:
- fixed memory leak
- ensure consistent ordering on mac linux and windows for fbx tree. (very important for material import to be deterministic)
- disabled incorrect warnings for fbx_material
- added compatibility code for /RootNode/ so compat is not broken
- Optimise FBX - directly import triangles
- remove debug messages
- add messages for mesh id, mesh re-import is sometimes slow and we need to know what mesh is being worked on
- correct culling settings on materials

.gitignore

@@ -5,6 +5,9 @@
 # Documentation generated by doxygen or from classes.xml
 doc/_build/
 
+# Clangd for vim
+.clangd/
+
 # Javascript specific
 *.bc
 
@@ -15,7 +18,6 @@ cmake-build-debug
 .gradle
 local.properties
 *.iml
-.idea
 .gradletasknamecache
 project.properties
 platform/android/java/app/libs/*

editor/editor_settings.cpp

@@ -183,8 +183,9 @@ void EditorSettings::_get_property_list(List<PropertyInfo> *p_list) const {
 
 		const VariantContainer *v = props.getptr(*k);
 
-		if (v->hide_from_editor)
+		if (v->hide_from_editor) {
 			continue;
+		}
 
 		_EVCSort vc;
 		vc.name = *k;

editor/import/resource_importer_scene.cpp

@@ -88,7 +88,6 @@ Ref<Animation> EditorSceneImporter::import_animation(const String &p_path, uint3
 //and you want to load the resulting file
 
 Node *EditorSceneImporter::import_scene_from_other_importer(const String &p_path, uint32_t p_flags, int p_bake_fps) {
-
 	return ResourceImporterScene::get_singleton()->import_scene_from_other_importer(this, p_path, p_flags, p_bake_fps);
 }
 
@@ -185,7 +184,6 @@ String ResourceImporterScene::get_resource_type() const {
 }
 
 bool ResourceImporterScene::get_option_visibility(const String &p_option, const Map<StringName, Variant> &p_options) const {
-
 	if (p_option.begins_with("animation/")) {
 		if (p_option != "animation/import" && !bool(p_options["animation/import"]))
 			return false;

main/tests/test_basis.cpp

@@ -89,6 +89,7 @@ Basis EulerToBasis(RotOrder mode, const Vector3 &p_rotation) {
 }
 
 Vector3 BasisToEuler(RotOrder mode, const Basis &p_rotation) {
+
 	switch (mode) {
 		case EulerXYZ:
 			return p_rotation.get_euler_xyz();
@@ -135,6 +136,7 @@ String get_rot_order_name(RotOrder ro) {
 }
 
 bool test_rotation(Vector3 deg_original_euler, RotOrder rot_order) {
+
 	// This test:
 	// 1. Converts the rotation vector from deg to rad.
 	// 2. Converts euler to basis.
@@ -316,7 +318,7 @@ void test_euler_conversion() {
 }
 
 MainLoop *test() {
-	OS::get_singleton()->print("Start euler conversion checks.\n");
+	OS::get_singleton()->print("Start euler conversion check.\n");
 	test_euler_conversion();
 
 	return NULL;

main/tests/test_main.cpp

@@ -65,6 +65,7 @@ const char **tests_get_names() {
 		"gd_bytecode",
 		"ordered_hash_map",
 		"astar",
+		"basis",
 		NULL
 	};
 
@@ -150,6 +151,10 @@ MainLoop *test_main(String p_test, const List<String> &p_args) {
 		return TestAStar::test();
 	}
 
+	if (p_test == "basis") {
+		return TestBasis::test();
+	}
+
 	print_line("Unknown test: " + p_test);
 	return NULL;
 }