-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a warning that docs are WIP and a status flag for articles #6817
Conversation
After we agree on this, |
First thing that comes to mind is how is this going to play out in the future? The engine keeps changing, documentation that is now up to date will become out of date again. Would there be some kind of hook that sets |
We don't have to look so far ahead. This is only needed right now to address the issue with massive changes in 4.0. We can reuse this or scrap it afterwards, we will see. Eithet way, it will involve manual labor. |
8f41441
to
5cd24fc
Compare
I would prefer if every page defaulted to up-to-date. Otherwise we need to ask contributors to review every single article and flag it as updated. By defaulting to up-to-date, we will quickly find out from users which pages are out of date and we can easily add the warning to just those pages |
I'll do broad strokes myself, and I'll make a tracker for all the areas so we can split the load. I'd prefer the default state to be cautious. Otherwise the point of this warning to most users is nil, until someone complains (while others stay silent and perhaps confused) |
On the other hand, if we release 4.0 and every article says its out of date, users are going to be very confused and upset. I wonder if there is a way through git to flag all the files that have been touched between two commits. Maybe we could flag only those files that haven't been touched at all in the last couple of years |
That is basically what I'll do tomorrow, but manually 🙃 |
After thinking about it and since I plan to do a manual pass today, defaulting to up to date should be okay and benefits in the following ways:
|
By default (no flag) articles are considered up-to-date, with the end goal to have no articles marked as outdated. Use `:article_outdated: True` at the top of an article to mark it as being outdated.
Tracker for outdated docsI'll mark the sections as I go through them. About
Getting started
Manual
Contributing
Community
Class reference
|
2D/Canvas layers: looking correct |
5cd24fc
to
978a13b
Compare
Depends on #6814.
This PR adds a togglable warning about docs being WIP, advising to pay attention to itself to learn if the page is up to date or not. By default every page is considered outdated. To mark it as up to date, we must add a flag to its metadata (a field at the top of the document), like
See
index.rst
for an example.Now, obviously, this is a lot of busywork to verify every article, but I think it's better to default to being outdated than to default to being up to date, because that's closer to the true state of the docs. Many articles still need an update pass, even though others have been updated or even rewritten. The outdated banner also has a call to action, so this should hopefully incentivize people to contribute or to at least validate the actuality of the docs.
If we don't agree on this, I can remake the defaults or implement the logic differently.
Here's how it looks (I made some adjustments to the admonition banners in general):