Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some C# examples for 4.0 #6693

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Jan 29, 2023

I have renamed everything I could find that was using the old names but I likely missed some, I intentionally left out the getting started tutorial as well as some physics tutorials that seemed too outdated and needed bigger changes so I thought it'd be better to update those in a separate PR.

@raulsntos raulsntos added bug topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jan 29, 2023
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted no issues, but will let it stay open a bit longer to give people more versed in Godot's C# stuff a chance to spot things too :) Nice work!

Copy link
Member

@paulloz paulloz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pesky float conversions 😭

tutorials/inputs/input_examples.rst Outdated Show resolved Hide resolved
tutorials/physics/ray-casting.rst Outdated Show resolved Hide resolved
tutorials/2d/custom_drawing_in_2d.rst Outdated Show resolved Hide resolved
tutorials/2d/custom_drawing_in_2d.rst Outdated Show resolved Hide resolved
@raulsntos
Copy link
Member Author

Thank you so much for the reviews. I missed a bunch of those conversions 😅

raulsntos and others added 2 commits February 2, 2023 03:49
- Rename members that have been renamed in Godot's C# API for 4.0.
- Change `delta` parameter type to `double`.
- Ensure parameters match base declaration.
- Other minor code fixes.
@mhilbrunner mhilbrunner merged commit b319da3 into godotengine:master Feb 4, 2023
@mhilbrunner
Copy link
Member

Thank you! 🎉 Merged.

@raulsntos raulsntos deleted the dotnet/renames branch February 4, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants