-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some C# examples for 4.0 #6693
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted no issues, but will let it stay open a bit longer to give people more versed in Godot's C# stuff a chance to spot things too :) Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pesky float conversions 😭
Thank you so much for the reviews. I missed a bunch of those conversions 😅 |
0a3c14f
to
cec45ed
Compare
- Rename members that have been renamed in Godot's C# API for 4.0. - Change `delta` parameter type to `double`. - Ensure parameters match base declaration. - Other minor code fixes.
Co-authored-by: Paul Joannon <[email protected]>
cec45ed
to
c716c00
Compare
Thank you! 🎉 Merged. |
delta
parameter type todouble
.I have renamed everything I could find that was using the old names but I likely missed some, I intentionally left out the getting started tutorial as well as some physics tutorials that seemed too outdated and needed bigger changes so I thought it'd be better to update those in a separate PR.