Clarify use of source_color in Shading Language #10119
Conversation
| hints for proper sRGB -> linear conversion (i.e. ``source_color``), as Godot's | ||
| 3D engine renders in linear color space. If this is not done, the texture will | ||
| appear washed out. | ||
| .. admonition:: Source Color |
There was a problem hiding this comment.
This is the first use of an admonition note with a custom title in the whole docs repo. I think it makes this more readable, but if this is against some style guide I can change this to use a subheader or standard note block instead.
It renders as something like this:
There was a problem hiding this comment.
I'll be trying this out whenever a note block could use a title, then. I don't mind reverting such changes back if it proves to be a problem. I think in most cases, a note with a title should be a subsection, though?
There was a problem hiding this comment.
I think so. I suspect that most notes will be fine without a special title
AThousandShips
added
enhancement
area:manual
| hints for proper sRGB -> linear conversion (i.e. ``source_color``), as Godot's | ||
| 3D engine renders in linear color space. If this is not done, the texture will | ||
| appear washed out. | ||
| .. admonition:: Source Color |
Rewrite section on using the source_color uniform hint. Content is mostly the same, but is more clear. Rename one instance of "shader hint" to "uniform hint". Adds a section header for Uniform hints.
tetrapod00
force-pushed
the
shader-source-color
branch
from
e137450
to
7303e57
Compare
|
Changes applied, plus one minor change to wrap the paragraphs to ~80 characters. |
|
Thank you! |
The rest of this section (Uniforms) can use some more work. It needs reorganization, more subheaders, and some rewrites for clarity. That will be a separate PR though.