Clarify use of source_color in Shading Language #10119
Open
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite section on using the source_color uniform hint. Content is mostly the same, but is more clear. Rename one instance of "shader hint" to "uniform hint". Adds a section header for Uniform hints.
tetrapod00
commented
Oct 20, 2024
| hints for proper sRGB -> linear conversion (i.e. ``source_color``), as Godot's | ||
| 3D engine renders in linear color space. If this is not done, the texture will | ||
| appear washed out. | ||
| .. admonition:: Source Color |
There was a problem hiding this comment.
This is the first use of an admonition note with a custom title in the whole docs repo. I think it makes this more readable, but if this is against some style guide I can change this to use a subheader or standard note block instead.
It renders as something like this:
AThousandShips
added
enhancement
area:manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of this section (Uniforms) can use some more work. It needs reorganization, more subheaders, and some rewrites for clarity. That will be a separate PR though.