Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dodge-the-Creeps to latest Godot version #790

Closed
wants to merge 1 commit into from
Closed

Update Dodge-the-Creeps to latest Godot version #790

wants to merge 1 commit into from

Conversation

Bromeon
Copy link

@Bromeon Bromeon commented Nov 15, 2022

Updates the Dodge-the-Creeps example to version godotengine/godot@4935493.

Tested on Windows.

@@ -23,7 +23,7 @@ func update_score(score):

func _on_StartButton_pressed():
$StartButton.hide()
emit_signal("start_game")
var _ignore = emit_signal("start_game")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godotengine/godot#69002 was just merged! You can safely remove var _ignore variable declarations as there will not be any warning (unless the user change its project settings).

@adamscott
Copy link
Member

Can you update the documentation code, while being at it?

@Bromeon
Copy link
Author

Bromeon commented Nov 27, 2022

Updated the example to remove the var _ignore = ... workaround.

Can you update the documentation code, while being at it?

Since I don't have that repo forked and don't know what exactly would need updating, I'd appreciate if someone who knows could do that directly 😉

@adamscott
Copy link
Member

Here. The GDScript of this directory inside the .rst files.

https://github.com/godotengine/godot-docs/tree/master/getting_started/first_2d_game

@Bromeon
Copy link
Author

Bromeon commented Nov 27, 2022

My GDScript changes are limited to two renamings:

  • offset -> progress
  • RigidDynamicBody2D -> RigidBody2D

I saw the first uses this in the docs:

mob_spawn_location.progress_ratio = randi()

is that correct? Should we not use progress_ratio = randf()?

@akien-mga
Copy link
Member

Yes it should be progress_ratio = randf().

@Bromeon
Copy link
Author

Bromeon commented Dec 5, 2022

Thanks for confirmation -- changed accordingly. Also squashed the commits to one.

@aaronfranke aaronfranke added this to the 4.0 milestone Jan 22, 2023
@akien-mga
Copy link
Member

Might have been superseded by #782, should check which changes may still be relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants