-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dodge-the-Creeps to latest Godot version #790
Update Dodge-the-Creeps to latest Godot version #790
Conversation
2d/dodge_the_creeps/HUD.gd
Outdated
@@ -23,7 +23,7 @@ func update_score(score): | |||
|
|||
func _on_StartButton_pressed(): | |||
$StartButton.hide() | |||
emit_signal("start_game") | |||
var _ignore = emit_signal("start_game") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
godotengine/godot#69002 was just merged! You can safely remove var _ignore
variable declarations as there will not be any warning (unless the user change its project settings).
Can you update the documentation code, while being at it? |
Updated the example to remove the
Since I don't have that repo forked and don't know what exactly would need updating, I'd appreciate if someone who knows could do that directly 😉 |
Here. The GDScript of this directory inside the https://github.com/godotengine/godot-docs/tree/master/getting_started/first_2d_game |
My GDScript changes are limited to two renamings:
I saw the first uses this in the docs: mob_spawn_location.progress_ratio = randi() is that correct? Should we not use |
Yes it should be |
Thanks for confirmation -- changed accordingly. Also squashed the commits to one. |
Might have been superseded by #782, should check which changes may still be relevant. |
Updates the Dodge-the-Creeps example to version godotengine/godot@4935493.
Tested on Windows.