Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PCK loading/unloading demo #751

Closed
wants to merge 5 commits into from

Conversation

rsubtil
Copy link

@rsubtil rsubtil commented Jul 7, 2022

Adds a demo for PCK unload functionality implemented at godotengine/godot#61286, as suggested.

voylin and others added 5 commits May 8, 2022 06:55
Update gui/input_mapping/KeyPersistence.gd

Co-authored-by: Aaron Franke <[email protected]>
Update gui/input_mapping/KeyPersistence.gd

Co-authored-by: Aaron Franke <[email protected]>
Update gui/input_mapping/KeyPersistence.gd

Co-authored-by: Aaron Franke <[email protected]>
…istenceKeyMaps3.x

[3.x] GUI Input Mapping Demo Persistent Key Mapping- Fixes godotengine#629
Fix typos in `webrct_signalling/README.md`
@Calinou
Copy link
Member

Calinou commented Jul 7, 2022

Could you open a pull request on the 4.0-dev branch? Unlike the main Godot repository, the master branch of godot-demo-projects targets Godot 3.x. Therefore, it should only contain demos that work on Godot 3.x.

If the feature is backported to 3.x, then the demo can also be backported to master here.

@rsubtil rsubtil changed the base branch from master to 4.0-dev July 7, 2022 15:27
@rsubtil
Copy link
Author

rsubtil commented Jul 7, 2022

Will do 👍. I tried changing branch but seems like it's bringing trouble, so I'll close this and remake the PR.

@rsubtil rsubtil closed this Jul 7, 2022
@Calinou
Copy link
Member

Calinou commented Jul 7, 2022

Superseded by #752.

@rsubtil rsubtil deleted the add_pck_loading branch July 7, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants