Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3D Scaling in 4.0-dev not working #856

Closed
voylin opened this issue Feb 25, 2023 · 4 comments
Closed

3D Scaling in 4.0-dev not working #856

voylin opened this issue Feb 25, 2023 · 4 comments
Labels
bug

Comments

@voylin
Copy link
Contributor

voylin commented Feb 25, 2023

Which demo project is affected:
3D scaling in viewport

OS/device including version:
Linux Arch lts

Issue description:
Filtering works, however the scaling does not work at all. I've been trying to fix this demo myself as I need it for some of my personal projects but I can't find what's wrong with it. Is this still a 4.0 bug or is there something I'm missing here? Setting the size of the subviewport does not work and the size 2D override doesn't seem to be doing anything.
@voylin voylin added the bug label Feb 25, 2023
@Calinou
Copy link
Member

Calinou commented Feb 25, 2023

The demo should be updated to use the built-in resolution scaling features that are new in 4.0.

However, the old approach should still be provided as an alternative – likely as a separate project. This is because the old approach is the only one that works when using the Compatibility (OpenGL) rendering method. It's also currently the only way to use nearest-neighbor filtering instead of bilinear filtering or FSR 1.0 (until godotengine/godot-proposals#4697 is implemented).

@Calinou Calinou mentioned this issue Feb 26, 2023
Open
@rcorre rcorre mentioned this issue Mar 18, 2023
Closed
rcorre added a commit to rcorre/godot-demo-projects that referenced this issue Mar 18, 2023
@rcorre
Update viewport scaling demo to 4.0.
18b578c 
Fixes godotengine#856.

The 3d_scaling demo was updated to use the built-in 3D scaling mechanisms
in the Forward+ renderer.

A new 3d_scaling_compat demo was added to demonstrate the legacy
SubViewport-based scaling method for the Compatibility renderer.
rcorre added a commit to rcorre/godot-demo-projects that referenced this issue Mar 19, 2023
@rcorre
Update viewport scaling demo to 4.0.
37aab55 
Fixes godotengine#856.

The 3d_scaling demo was updated to use the built-in 3D scaling mechanisms
in the Forward+ renderer.

A new 3d_scaling_compat demo was added to demonstrate the legacy
SubViewport-based scaling method for the Compatibility renderer.
@Nrosa01
Copy link

Nrosa01 commented Sep 27, 2023

What are those built-in resolution scaling features in godot 4? I tried the scaling project because I needed to do something similar and faced the same problem

@Calinou
Copy link
Member

Calinou commented Sep 27, 2023

What are those built-in resolution scaling features in godot 4?

https://docs.godotengine.org/en/latest/tutorials/3d/resolution_scaling.html

rcorre added a commit to rcorre/godot-demo-projects that referenced this issue Feb 8, 2024
@rcorre @AThousandShips
Update viewport scaling demo to 4.0.
884a57b 
Fixes godotengine#856.

The 3d_scaling demo was updated to use the built-in 3D scaling mechanisms
in the Forward+ renderer.

A new 3d_scaling_compat demo was added to demonstrate the legacy
SubViewport-based scaling method for the Compatibility renderer.

Co-authored-by: A Thousand Ships <[email protected]>
@Calinou
Copy link
Member

Calinou commented Feb 13, 2024 •
edited
Loading

Fixed by #891 being manually merged in 722bd11.

@Calinou Calinou closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update viewport scaling demo to 4.0. rcorre/godot-demo-projects
3 participants
@Calinou @voylin @Nrosa01