Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSX] Add OSX universal build support. #634

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

Faless
Copy link
Contributor

@Faless Faless commented Sep 29, 2021

This is more of the work by @bruvzg in #529 .
My other two PRs combined were not the same, as they did not add the possibility to create a universal binary (i.e. a library containing both x64 and arm64 binaries).

This PR adds it and make the universal build the default and the only one in CI.
I'm sorry for the big mess 😞 (I'll try to backport to the 3.3 branch once confrimed).

@Faless Faless added enhancement This is an enhancement on the current functionality platform:macos topic:buildsystem Related to the buildsystem or CI setup labels Sep 29, 2021
@akien-mga akien-mga added this to the 4.0 milestone Sep 29, 2021
@akien-mga
Copy link
Member

(I'll try to backport to the 3.3 branch once confrimed).

Note that like for Godot, this should go to 3.x first. (And then it can likely be cherry-picked for 3.3 too.)

@akien-mga akien-mga merged commit 230fd4b into godotengine:master Oct 1, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality platform:macos topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants