-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal - add installation folder #132
Comments
Is it possible to only download a part of the repository? Then we can only
get addons/the_addon and maybe some other special directories (is there a
separate place for editor extensions), and other files can be on the
asset's repository that aren't downloaded, like source code, docs, READMEs,
etc.
…On 2 March 2018 at 01:31, Bastiaan Olij ***@***.***> wrote:
Right now when an asset is downloaded the files are placed directly in the
root of your project folder. You need to include the folder structure in
your asset and files such as the readme and license files that often reside
in the root of a github project end up in the root of your project folder.
This can get very messy if you use multiple assets in your project.
It would be nice if it was possible to specify a folder into which the
asset should be placed. This can still be the root of the project for
assets such as demos but for other projects it could be something like
"addon/myaddon" and the contents of the git repository gets placed in that.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#132>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGVmPb8uqtLsaQlhWQW27eR-7Dgf0FC0ks5taMsxgaJpZM4SZY1C>
.
|
Yes, the interface in Godot allows you to select the files to download. All files in the root are unselected by default (this avoids downloading readme, license, etc.). This is probably a thing for the main engine repo though. Also, see godotengine/godot#6023 |
@punto- as vnen said, yes you can already select but I think it is actually important to have the readme and license downloaded, but placed in the add on folder @vnen a I didn't see that though I do believe that the default installation location should be set in the asset library itself especially because paths inside resources and scenes will not change along. |
What if we provide a subdirectory inside the repository (when the asset is
submitted) that contains the final asset, and other files (like source
code) can be outside of it? Default can be empty. Then instead of doing:
root_of_repo -> root_of_project
it can be
root_of_repo/asset_subdir -> root_of_project
Otherwise for example all addons that use gdnative will have to split into
2 repositories, one for the source code?
…On 2 March 2018 at 01:53, Bastiaan Olij ***@***.***> wrote:
@punto- <https://github.com/punto-> as vnen said, yes you can already
select but I think it is actually important to have the readme and license
downloaded, but placed in the add on folder
@vnen <https://github.com/vnen> a I didn't see that though I do believe
that the default installation location should be set in the asset library
itself especially because paths inside resources and scenes will not change
along.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#132 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGVmPaOmM7_bfiU7v5wvVpXHd_U1mMP6ks5taNBWgaJpZM4SZY1C>
.
|
But that's not what happens at all. All files are downloaded and selected by default. |
@punto- I actually like the idea of being able to select a subfolder as the root of what is being downloaded. That would also allow me to have a single repository instead of the two repositories I maintain right now for each asset. @YeldhamDev that can be fixed, but I'm not a big fan of that as a solution either. |
I've been struggling with this with Gut for awhile now. I think the default checkmarks in the engine would be a good short putt. One thing I'm concerned about is that if I have a LICENSE.md in the root of my project, and someone doesn't uncheck it, then now their project has my same LICENSE.md. Same goes for README.md and CHANGES.md and any other files, but the LICENSE.md probably has the worst possible repercussions. |
Closing in favor of godotengine/godot-proposals#554. |
Right now when an asset is downloaded the files are placed directly in the root of your project folder. You need to include the folder structure in your asset and files such as the readme and license files that often reside in the root of a github project end up in the root of your project folder. This can get very messy if you use multiple assets in your project.
It would be nice if it was possible to specify a folder into which the asset should be placed. This can still be the root of the project for assets such as demos but for other projects it could be something like "addon/myaddon" and the contents of the git repository gets placed in that.
The text was updated successfully, but these errors were encountered: