Feature transform methods 3 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Feb 7, 2020
|
@toasteater - I've enacted the requested changes to comments. |
tom-leys
force-pushed
the
feature_transform_methods_3
branch
from
e4ea179 to
4db4fef
Compare
- Add tests for transposed dot product, fix visibility and doc comments
tom-leys
force-pushed
the
feature_transform_methods_3
branch
from
e56b457 to
9f9103c
Compare
|
Please review again @toasteater, @karroffel |
ghost
approved these changes
Feb 19, 2020
ghost
added this to the 
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets have another go at adding some methods shall we?
Second attempt from #208