Implement the basics of built-in vector types #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2023
Closed
ttencate
force-pushed
the
feature/builtins
branch
from
4c28670 to
f743d3a
Compare
Bromeon
reviewed
Jan 17, 2023
Comment on lines
100
to
162
| // vector += vector | ||
| impl std::ops::$operator for $vector { | ||
| fn $func(&mut self, rhs: $vector) { | ||
| $( | ||
| self.$components.$func(rhs.$components); | ||
| )* | ||
| } | ||
| } | ||
|
|
||
| // vector += scalar | ||
| impl std::ops::$operator<$scalar> for $vector { | ||
| fn $func(&mut self, rhs: $scalar) { | ||
| $( | ||
| self.$components.$func(rhs); | ||
| )* | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
See above.
In general, the operation a @= b should be provided if and only if a = a @ b is provided.
(for any operator @)
ttencate
force-pushed
the
feature/builtins
branch
2 times, most recently
from
d1e6e61 to
1930877
Compare
|
I think I addressed all your comments, PTAL. |
For Vector{2,3,4}{,i} this implements:
- public fields
- constructors
- constants
- operators
- indexing by axis
- (private) conversions to/from glam types
- Display
- a couple of functions like `abs()` and `length()` for demonstration
See also godot-rust#6.
ttencate
force-pushed
the
feature/builtins
branch
from
1930877 to
66a487a
Compare
Bromeon
reviewed
Jan 20, 2023
tryBuild failed: |
|
bors r+ |
|
Build succeeded: |
|
This is a great foundation for vector types, thank you very much for this PR! 🚀 I added some minor amendments in a 2nd commit. |
|
Oh, now I noticed that it's already merged. Still getting used to GitHub's code review workflow... Tiny additional PR coming up... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Vector{2,3,4}{,i} this implements:
abs()andlength()for demonstrationSee also #6.
This PR supersedes #66.