Gd::upcast_ref() + Gd::upcast_mut()
#558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Remove Declarer::scoped_mut() - no need to go through bind() for changes in base RefCounted; any accesses to user objects (e.g. destruction if refc=0) would bind anyway. * DynMemory::maybe_*_ref() methods now accept &mut RawGd<T> instead of &RawGd<T>. This expresses the mutation that happens better. * RawGd::as_object() returns &Object directly. * Rename RawGd::as_ref_counted -> with_ref_counted.
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Gd::upcast_ref()andGd::upcast_mut(). They have no direct use due toDereftrait, but can be useful in generic programming:Also took the opportunity to clean up quite a few things around
Derefand casting, which were handled entirely separately in the past. Most of the work is done -- there's stillRawGd::with_ref_counted()which I'd like to align withas_object(), but I can't spend more time on this right now.As a side effect, some of the object-swap checks (#23) now got even stricter. You can basically not do anything useful anymore, indicating that this is a bug that must always be fixed.
More details in commit messages.