check.sh: find Godot 4 executable when available as godot
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, did not add the else branch... One sec. |
yannick-was-taken
force-pushed
the
qol/godot-binary-lookup
branch
from
857b407 to
b5f15ac
Compare
Bromeon
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Thanks a lot! Very nice that you check the version, because Godot 3 executables are regularly called godot and we still recommend that in gdnative.
yannick-was-taken
force-pushed
the
qol/godot-binary-lookup
branch
from
b5f15ac to
22a40c2
Compare
Bromeon
reviewed
Apr 6, 2023
Bromeon
added
quality-of-life
yannick-was-taken
force-pushed
the
qol/godot-binary-lookup
branch
from
22a40c2 to
a8a1084
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Some package managers (Arch Linux) install Godot 4.x as
godotin the PATH. This is currently not correctly dealt with by check.sh, requiring the user to set GODOT4_BIN manually.The Solution
If
godotis available,check.shnow inspects the version of that Godot installation, and if 4.x, accepts it gladly, removing the need to manually set GODOT4_BIN.Detail
The version check applies the regex
^4\.to the version returned bygodot --version. An example version (the one available in Arch Linux's community repo) is4.0.1.stable.arch_linux.