-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebuilt Godot artifacts #211
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivate) Rename opaque pointer types to highlight their private nature. Needs an update in packed_array.rs because it accidentally uses private implementation details.
Also update artifacts repo + branch version to "4.0.1"
…ic analysis) A directory /.generated in the repo root seems to _mostly_ work, but on CLion it needs an extra "Cargo sync" in fresh/cleaned projects. This creates extra friction that a crate-local `gen` directory doesn't have. Maybe reconsider this once IDEs handle things better.
Bromeon
added
quality-of-life
No new functionality, but improves ergonomics/internals
c: tooling
CI, automation, tools
labels
Apr 1, 2023
bors try |
tryBuild failed: |
Bromeon
force-pushed
the
feature/reuse-artifacts
branch
from
April 1, 2023 15:09
359d13d
to
22e0288
Compare
bors try |
tryBuild succeeded: |
bors r+ |
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: tooling
CI, automation, tools
quality-of-life
No new functionality, but improves ergonomics/internals
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12
Closes #107
From now on, gdext by default fetches pre-generated versions of these files, published in the
godot4-prebuilt
repo:extension_api.json
(from Godot binary)gdextension_interface.h
(from Godot binary)gdextension_interface.rs
(through bindgen -- currently supports 3 platforms)This has several benefits:
Using a custom Godot binary
It is still possible to generate those files locally like before, through the use of the
custom-godot
feature on thegodot
crate.This is necessary for any platform/configuration different from the 3 main supported ones (because bindgen generates different Rust bindings), as well as any in-development or modified Godot versions.
Changing the Godot release
By default, the latest Godot release is used as input to gdext. Switching between different Godot versions is easily possible, although a bit cumbersome.
If you want to use an older version
4.0
, add this to your workspace (not sub-crate)Cargo.toml
:We're looking into ways to simplify this. In a crates.io release (#2), we would need to rethink this anyway, mapping Godot versions to Rust release versions (which is not trivial).