Rename Array -> VariantArray, TypedArray -> Array
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
quality-of-life
tryBuild succeeded: |
|
bors r+ |
|
Build succeeded: |
Closed
bors bot
added a commit
that referenced
this pull request
May 8, 2023
252: Implement `#[func]` for static functions r=Bromeon a=lilizoey Takes over from #210 Adds support for static methods in classes. also replaces tabs with spaces in `signature.rs`. thanks a lot to `@ttencate!` it was very straightforward to make this work based on what they'd already done. from what i can tell, there are no static virtual methods. so we dont need to implement support for that. im not sure if there ever will be but it doesn't seem likely to me at least. it might be worth it to move more of this logic into procedural macros eventually. closes #175 262: Correct documentation on Array r=Bromeon a=Mercerenies Per #151, the struct `TypedArray` has been renamed. This MR updates stale documentation to reflect the new naming scheme. 266: Improve `cargo check` times for incremental changes to `godot-core` r=Bromeon a=lilizoey On my machine, this change makes the time `cargo check` takes to run go from 48 seconds to 11 seconds when making an incremental change to `godot-core`. in this case tested by adding/removing a single method to/from `Basis`. I've seen it be as low as 2 seconds sometimes but im not entirely sure why that happens. Co-authored-by: Thomas ten Cate <[email protected]> Co-authored-by: Lili Zoey <[email protected]> Co-authored-by: Silvio Mayolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggests that
Array<T>is the default and preferred way of using arrays (with type-safe elements), whileVariantArrayis more a special case of untyped arrays.We probably need to observe usage to see whether this makes sense. An alternative would be
VArrayinstead ofVariantArray, but that would require a frequent occurrence so that the shortened identifier pays off.bors try