Use nightly.link for artifact download -> removes the need for PAT

Fixes #14
godot-rust · Nov 6, 2022 · a64f224 · a64f224
1 parent 84fbe94
commit a64f224
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 29 deletions.
diff --git a/.github/composite/godot/action.yml b/.github/composite/godot/action.yml
@@ -14,10 +14,6 @@ inputs:
     required: true
     description: "Filename of the Godot executable"
 
-  github-pat:
-    required: true
-    description: "GitHub PAT (personal access token) to download artifacts from other repos"
-
   rust-toolchain:
     required: false
     default: 'stable'
@@ -34,36 +30,26 @@ runs:
   steps:
     - uses: actions/checkout@v3
 
+    # Replaces also backspaces on Windows, since they cause problems in Bash
+    - name: "Store variable to Godot binary"
+      run: |
+        runnerDir=$(echo "${{ runner.temp }}" | sed "s!\\\\!/!")
+        echo "RUNNER_DIR=$runnerDir" >> $GITHUB_ENV
+        echo "GODOT4_BIN=$runnerDir/godot_bin/${{ inputs.binary-filename }}" >> $GITHUB_ENV
+      shell: bash
+
 #    - name: "Check cache for installed Godot version"
 #      id: "cache-godot"
 #      uses: actions/cache@v3
 #      with:
 #        path: ${{ runner.temp }}/godot_bin
-#        #key: godot-${{ runner.os }}-v${{ inputs.godot-ver }}
-#        key: ${{ inputs.artifact-name }}
+#        key: ${{ inputs.artifact-name }}-v${{ inputs.godot-ver }}
 
     - name: "Download Godot artifact"
 #      if: steps.cache-godot.outputs.cache-hit != 'true'
-      # https://github.com/dawidd6/action-download-artifact
-      uses: dawidd6/action-download-artifact@v2
-      with:
-        # Downloads and unzips the artifact with {name} of the latest run of specified {workflow}
-        path: ${{ runner.temp }}/godot_bin
-        github_token: ${{ inputs.github-pat }}
-        repo: Bromeon/godot4-nightly
-        branch: master
-        workflow: compile-godot.yml
-        workflow_conclusion: success
-        name: ${{ inputs.artifact-name }}
-        # Search for the last workflow run, which stored an artifact named as in `name` input
-        search_artifacts: true
-
-    # Replaces also backspaces on Windows, since they cause problems in Bash
-    - name: "Store variable to Godot binary"
       run: |
-        runnerDir=$(echo "${{ runner.temp }}" | sed "s!\\\\!/!")
-        echo "RUNNER_DIR=$runnerDir" >> $GITHUB_ENV
-        echo "GODOT4_BIN=$runnerDir/godot_bin/${{ inputs.binary-filename }}" >> $GITHUB_ENV
+        curl https://nightly.link/Bromeon/godot4-nightly/workflows/compile-godot/master/${{ inputs.artifact-name }}.zip -Lo artifact.zip
+        unzip artifact.zip -d $RUNNER_DIR/godot_bin
       shell: bash
 
     # The chmod seems still necessary, although applied before uploading artifact. Possibly modes are not preserved.
@@ -133,6 +119,7 @@ runs:
       shell: bash
 
     - name: "Conclusion"
+      if: always()
       run: |
         echo "Evaluate conclusion ($OUTCOME)"
         
@@ -165,6 +152,4 @@ runs:
             exit 4
             ;;
         esac
-
       shell: bash
-      if: always()
diff --git a/.github/external-config/licenserc.yml b/.github/external-config/licenserc.yml
@@ -14,7 +14,7 @@ header:
     - '.github/**/*.yml'
 
   paths-ignore:
-    - 'demo-project'
+    - 'examples'
 
   comment: on-failure
 

diff --git a/.github/workflows/minimal-ci.yml b/.github/workflows/minimal-ci.yml
@@ -99,7 +99,6 @@ jobs:
         with:
           artifact-name: godot-${{ matrix.name }}
           binary-filename: ${{ matrix.godot-binary }}
-          github-pat: ${{ secrets.ARTIFACT_DOWNLOADER_PAT }}
           #godot_ver: ${{ matrix.godot }}
 
   license-guard: