Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace password authentication with oauth #1069

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

DaanRademaker
Copy link
Collaborator

Databricks is deprecating password authentication 10th of july (very fast indeed).
We need to move to oauth asap.

  • change account client and workspace client to use client-id and client-secret of a service principal
  • use Config class of databricks to create authentication headers for all parts of code that still use normal requests (not the sdk client)

I think we should bump this as a patch version. I added a really specific exception that users need to change to service principal. If we do patch we know users will get a useful exception on time instead of authorization issues.

@DaanRademaker DaanRademaker force-pushed the add_oauth branch 2 times, most recently from acf24cc to 743b8f3 Compare July 2, 2024 08:02
Copy link
Collaborator

@dan1elt0m dan1elt0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from some small comments

README.md Outdated Show resolved Hide resolved
aws-lambda/src/databricks_cdk/utils.py Outdated Show resolved Hide resolved
@DaanRademaker DaanRademaker merged commit 28a7803 into godatadriven:main Jul 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants