Add namespaced support to objects other than namespaces
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is in an RFC state and isn't complete (e.g., missing tests). If folks like the API changes and direction I'll finish this off. |
|
@silasbw I love what you are doing here and that it's so few lines of code. I would add more comments explaining what you are doing in the base class for future contributor understanding and continue along this thread with tests etc. This will be a breaking change but I'm ok with that. |
|
@silasbw I think this is a great direction to go. Good stuff! |
There are several objects/entities that are namespaced by Kubernetes objects.
`/api/v1/namespaces/{namespace}/pods/{name}/log` is an obvious one, but there's
more. For example:
* Proxy objects (e.g., `/api/v1/namespaces/{namespace}/services/{name}/proxy/`)
* Deployment related objects (e.g., `/apis/extensions/v1beta1/namespaces/{namespace}/deployments/{name}/rollback`)
* ...
This PR implements a story for handling these cases and changes the
documentation to encourage users to use namespaced functionality by default
(e.g., `api.ns.po('foo').get(print)` vs `api.ns.po.get(foo, print)`).
|
I took a pass at fleshing this PR out. I think it's ready for a review. |
|
THis looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several objects/entities that are namespaced by Kubernetes objects.
/api/v1/namespaces/{namespace}/pods/{name}/logis an obvious one, but there'smore. For example:
/api/v1/namespaces/{namespace}/services/{name}/proxy/)/apis/extensions/v1beta1/namespaces/{namespace}/deployments/{name}/rollback)This PR implements a story for handling these cases and changes the
documentation to encourage users to use namespaced functionality by default
(e.g.,
api.ns.po('foo').get(print)vsapi.ns.po.get(foo, print)).