Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend kubernetes-client to openshift-client #105

Closed
debianmaster opened this issue May 30, 2017 · 5 comments
Closed

extend kubernetes-client to openshift-client #105

debianmaster opened this issue May 30, 2017 · 5 comments

Comments

@debianmaster
Copy link

i would like to extend this k8s library to openshift which has additional objects like Route DeploymentConfig etc can you please guide me the steps that would be involved ?

silasbw pushed a commit that referenced this issue May 31, 2017
silasbw pushed a commit that referenced this issue May 31, 2017
@silasbw
Copy link
Contributor

silasbw commented May 31, 2017

@debianmaster created a PR that has a rough outline for adding support to this code base for new "API groups": https://github.com/godaddy/kubernetes-client/pull/106/files#diff-6a3371457528722a734f3c51d9238c13R33

I notice https://github.com/debianmaster/openshift-client -- cool! I think we should be able to expose the right interface from kubernetes-client so that openshift-client can depend on kubernetes-client (instead of forking it). Would you be interested in trying that approach?

@debianmaster
Copy link
Author

@silasbw definitely ! i dont want to re-invent wheel. I think we should be able to expose the right interface from kubernetes-client so that openshift-client can depend on kubernetes-client i think this is the ideal way. lets chat more on the PR you created.

@silasbw
Copy link
Contributor

silasbw commented May 31, 2017

@debianmaster check out https://github.com/silasbw/openshift-client-scratch. Does that seem like a good approach?

Tests are the main thing missing -- we can pull https://github.com/godaddy/kubernetes-client/blob/master/test/common.js out into a module (e.g., kubernetes-client-test) so other packages can re-use it.

silasbw added a commit that referenced this issue May 31, 2017
@debianmaster
Copy link
Author

@silasbw sorry the late reply. in travel right now. but i will check and get back in a day.

@silasbw
Copy link
Contributor

silasbw commented Jun 8, 2017

Seems like we have a path forward with https://github.com/debianmaster/openshift-client, so I'm going to close this issue. Feel free to re-open if we need more discussion.

@silasbw silasbw closed this as completed Jun 8, 2017
kdamedhaar added a commit to kdamedhaar/k8-client that referenced this issue Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants