Make brightness bar optional #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffgiraldez
previously requested changes
Oct 25, 2022
| @Composable | ||
| fun HarmonyColorPicker( | ||
| modifier: Modifier = Modifier, | ||
| harmonyMode: ColorHarmonyMode, | ||
| color: HsvColor, | ||
| fixedBrightness: Float? = null, |
There was a problem hiding this comment.
Please, to keep consistency with ClassicColorPicker, please rename it to showBrightnessBar.
if a user wants a specific brightness, it should set showBrightnessBar to false and set the brightness in the provided color.
There was a problem hiding this comment.
@ffgiraldez thanks for pointing that out. I didn't notice ClassicColorPicker had that. Updated now
riggaroo
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for the feedback provided in #27, the brightness bar change will be isolated for review once #27 gets merged.