support multi-platform #4
Conversation
|
Hi @HuixingWong, thanks so much for picking this up! Indeed its a request that #2 also is asking for :) I've run it locally, but I think there is something wrong with the Canvas drawing logic on Desktop, it looks like it maybe doesn't support On startup on a phone: On startup on Desktop: It also seems to be drawing a weird color when you play around with the Hue Bar which I haven't seen on the Android version (looks pretty but its not correct 😄 )
|
…el here and 'Modulate' mode no required Android API level 29 and above )
resolve some changes
|
Nice, modulate seems to fix that issue 🎉 I'll give it another look through and test everything again, but this is looking really good, thanks so much! |
|
I was actually curious about the Blend Mode issue, and have now discovered it does the same thing on API levels lower than 29 😭 I see you changed it to Modulate, I wonder if that works on lower Android API levels. Let me investigate a bit more and see! |
| api(compose.runtime) | ||
| api(compose.foundation) | ||
| api(compose.material) | ||
| implementation("com.github.ajalt.colormath:colormath:3.1.1") |
There was a problem hiding this comment.
Mostly thinking out loud here, but I'm wondering if there isn't a way to only use this dependency only if its the Desktop version, and if that makes sense to do. I think all we need it for is color conversions to and from HSV right?
There was a problem hiding this comment.
It's true that we can rely on this only on the desktop, but there are a lot of color conversion tools in this library, and since I don't know so much about color things , it might be useful to keep it if you want to expand other functions for this library in the future, What do you think?
There was a problem hiding this comment.
Let me give it a bit more thinking and chat with the rest of the GoDaddy Studio Android Team about it tomorrow.
Otherwise, the PR looks good and it is now working for me on Desktop. I'll revert back tomorrow 👍🏻
There was a problem hiding this comment.
Alright I think we are good to go with this library 💯 Thanks so much for the contribution, merging it now.
Hello, i like your library and want using this on a multi-platform project so i make a small change for support it