Use rememberUpdatedState to prevent stale lambda capture #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a composable passes a lambda argument down to other composables via wrapping, lambda gets captured which may not read the latest state when executed. `rememberUpdatedState` fixes this problem.
|
Hi, @halilozercan thanks for this fix. Could you please also add it to the HarmonyColorPicker composable, to keep both in sync |
|
@halilozercan thanks for spotting this - i've made a change in #30 for both pickers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a composable passes a lambda argument down to other composables via wrapping, lambda gets captured which may not read the latest state when executed.
rememberUpdatedStatefixes this problem.