Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak categories in support of new categories within the Gutenberg plugin #1535

Merged
merged 3 commits into from
Jun 22, 2020

Conversation

richtabor
Copy link
Contributor

Description

Adds check for new categories and organizes the blocks in the respective new category provided by the Gutenberg plugin (WordPress/gutenberg#19279).

Types of changes

New feature + fallback for non-Gutenberg activations.

How has this been tested?

Tested with and without Gutenberg. Without Gutenberg active, there is no change to the current categorization of blocks. With Gutenberg the blocks are assigned to the new categories.

Checklist:

  • My code is tested

@richtabor richtabor added [Type] Enhancement Something new that adds functionality [Priority] Low This issue/pull request is not immediate [Status] In Progress Tracking issues with work in progress [Type] Gutenberg Issues/PRs related to the current version of the Gutenberg plugin labels Jun 12, 2020
@richtabor richtabor added this to the Next Release milestone Jun 12, 2020
@richtabor richtabor self-assigned this Jun 12, 2020
@cypress
Copy link

cypress bot commented Jun 12, 2020



Test summary

90 0 0 0


Run details

Project CoBlocks
Status Passed
Commit a45e8e9
Started Jun 12, 2020 7:08 PM
Ended Jun 12, 2020 7:12 PM
Duration 03:28 💡
OS Linux Debian - 10.4
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly in my testing. Works with and without the Gutenberg plugin active. LGTM.

@AnthonyLedesma AnthonyLedesma merged commit 61484d8 into master Jun 22, 2020
@AnthonyLedesma AnthonyLedesma deleted the tweak/categories branch June 22, 2020 19:43
@jrtashjian jrtashjian removed the [Status] In Progress Tracking issues with work in progress label Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low This issue/pull request is not immediate [Type] Enhancement Something new that adds functionality [Type] Gutenberg Issues/PRs related to the current version of the Gutenberg plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants