Merge branch 'feature/improve-error-handling' into dev

README.md

@@ -206,12 +206,13 @@ git flow feature finish upgrade-mirror
 
 - [x] Travis Testing
 - [x] Asynchronous redux-form validation (detect duplicate email)
+- [x] Error handling
+  - reference: [Checklist: Best Practices of Node.JS Error Handling](http://goldbergyoni.com/checklist-best-practices-of-node-js-error-handling/)
 - [ ] Pagination Mechanism
 
 ### v1.0+
 
 - [ ] Social Login
-- [ ] [Error handling](http://goldbergyoni.com/checklist-best-practices-of-node-js-error-handling/)
 - [ ] Disable submit button when form submitting
 - [ ] Todo#Update API & Todo#Edit Functionality
 - [ ] Mail System

src/common/actions/errorActions.js

@@ -1,3 +1,4 @@
+import Errors from '../constants/Errors';
 import actionTypes from '../constants/actionTypes';
 
 export const pushError = (error, meta) => {
@@ -11,6 +12,9 @@ export const pushError = (error, meta) => {
 };
 
 export const pushErrors = (errors) => {
+  if (errors && errors.length === undefined) {
+    return pushError(Errors.UNKNOWN_EXCEPTION, errors);
+  }
   return {
     type: actionTypes.PUSH_ERRORS,
     errors,

src/common/components/utils/ErrorList.js

@@ -33,6 +33,12 @@ let ErrorList = ({ errors, dispatch }) => (
           <p key="1">
             {error.meta.path && `(at path '${error.meta.path}')`}
           </p>
+        ), (
+          <p key="2">
+            {error.code === Errors.UNKNOWN_EXCEPTION.code && (
+              <span>{error.meta.toString()}</span>
+            )}
+          </p>
         )]}
       </div>
     ))}

src/server/app.js

@@ -15,6 +15,16 @@ const appPromise = new Promise((resolve, reject) => {
   const app = express();
   app.set('env', env);
 
+  // error handler for the whole app process
+  process.on('uncaughtException', (err) => {
+    console.log('uncaughtException', err);
+    process.exit(1);
+  });
+
+  process.on('unhandledRejection', (reason, p) => {
+    throw reason;
+  });
+
   // initialize firebase
   if (configs.firebase && clientConfigs.firebase) {
     let firebase = require('firebase');
@@ -36,6 +46,15 @@ const appPromise = new Promise((resolve, reject) => {
       console.log('[Service] [Mongo]\tenabled');
       middlewares({ app });
       routes({ app });
+      // error handler for the current request
+      app.use((err, req, res, next) => {
+        console.error(err.stack);
+        if (env !== 'production') {
+          res.status(500).send(`<pre>${err.stack}</pre>`);
+        } else {
+          res.status(500).send('Service Unavailable');
+        }
+      });
       return resolve(app);
     });
   } else {