Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast: append new line at the end of file #329

Merged
merged 2 commits into from
Dec 8, 2022
Merged

ast: append new line at the end of file #329

merged 2 commits into from
Dec 8, 2022

Conversation

kurochan
Copy link
Contributor

@kurochan kurochan commented Dec 5, 2022 •
edited
Loading

According to the POSIX Stndard, The definition of a LINE is,

A sequence of zero or more non- characters plus a terminating character.

https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

I think there should be end with \n on generated yaml file.

@kurochan kurochan mentioned this pull request Dec 5, 2022
Merged
@kurochan
Copy link
Contributor Author

kurochan commented Dec 5, 2022

@goccy I fixed test code. Could you approve to run test?

@goccy
Copy link
Owner

goccy commented Dec 8, 2022

Thank you for your contribution ! LGTM

@goccy goccy merged commit dc3fed8 into goccy:master Dec 8, 2022
@suzuki-shunsuke suzuki-shunsuke mentioned this pull request Jan 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kurochan @goccy