Resolve 'creation of dynamic propery' on Core\ApiClient #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Client Resolve issues exposed by deprecated messages introduced on PHP8.2 which indicate future breaking changes on the next major release cycle. - Deprecated: Creation of dynamic property GoCardlessPro\Core\ApiClient::$error_on_idempotency_conflict is deprecated in /<secret_project>/vendor/gocardless/gocardless-pro/lib/Core/ApiClient.php on line 28 - Deprecated: Creation of dynamic property GoCardlessPro\Core\ApiClient::$http_client is deprecated in /<secret_project>/vendor/gocardless/gocardless-pro/lib/Core/ApiClient.php on line 27
fefas
commented
Oct 27, 2023
| @@ -15,6 +15,9 @@ | |||
| */ | |||
| class ApiClient | |||
| { | |||
| public $http_client; | |||
| public $error_on_idempotency_conflict; | |||
There was a problem hiding this comment.
It could be done via construct promoted property as well. Let me know if this is the wanted approach so I can update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issues exposed by deprecated messages introduced on PHP8.2 which indicate future breaking changes on the next major release cycle.
Deprecated: Creation of dynamic property GoCardlessPro\Core\ApiClient::$error_on_idempotency_conflict is deprecated in /<secret_project>/vendor/gocardless/gocardless-pro/lib/Core/ApiClient.php on line 28Deprecated: Creation of dynamic property GoCardlessPro\Core\ApiClient::$http_client is deprecated in /<secret_project>/vendor/gocardless/gocardless-pro/lib/Core/ApiClient.php on line 27