-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially support imaxabs
for SV-COMP
#1519
base: master
Are you sure you want to change the base?
Conversation
This is needed for sv-benchmarks Juliet no-overflow tasks involving sqrt. We used this at SV-COMP 2024, before the option existed.
I reverted the questionable cast refinement, but MacOS CI doesn't pass still. Apparently there are CIL differences even on the non- Ubuntu: #line 9
tmp = imaxabs(data);
#line 9
if (tmp < 100L) {
#line 11
__goblint_check(data < 100L);
#line 12
__goblint_check(-100L < data);
#line 13
result = data * data;
} MacOS: #line 9
tmp = imaxabs((intmax_t )data);
#line 9
if (tmp < (intmax_t __attribute__((__availability__(macosx,introduced=10.4))) )100) {
#line 11
__goblint_check(data < 100LL);
#line 12
__goblint_check(-100LL < data);
#line 13
result = data * data;
} I guess this has something to do with the following type definitions.
MacOS:
Both are 64bit, so |
imaxabs
for SV-COMPimaxabs
for SV-COMP
This extends #1254 to support
imaxabs
on theintmax_t
type, which some Juliet tasks in SV-COMP use.Changes
Actually verifying those Juliet tasks required a bit more changes:
intmax_t
is looked up from thetypedef
in the program. So this can bypass make sizes of primitive types configurable with current machine as default #54.ana.float.evaluate_math_functions
is enabled in svcomp24 and svcomp confs. We used the C stubs to evaluatesqrt
and friends in SV-COMP 2024, but More precise abstractions of trigonometric functions using c-stubs #1277 added this option, which is off by default. So right now we couldn't even solve the similar tasks on smaller types that we could verify at SV-COMP 2024. I don't know if this will be a problem for soundness in SV-COMP. If so, then we'll need some non-stub implementation of floating pointsqrt
to solve these tasks, of which there is a lot of.Casts around the refinement are somehow different in these tasks, which required handling of float-integer casts inBaseInvariant
. I don't know if this is correct because previously only various float-float casts were supported and everything else was considered "incompatible types". It's not clear whether these are supposed to be impossible in the AST according to the standard or just were unsupported in the initial implementation.imaxabs
for SV-COMP #1519 (comment)). This fixes the problem by unrolling cast types in refinement.TODO