-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mutex-meet
for malloc after thread creation
#1492
Conversation
That doesn't restrict unprotected invariants to a single variable, which if missing, causes |
analyzer/src/analyses/apron/relationPriv.apron.ml Lines 500 to 504 in 896f236
get_mutex_global_g_with_mutex_inits_atomic doesn't have such condition and always does the join (with non-bottom), which makes everything fine.I wonder if also checking RD.mem_var get_mutex_global_g g_var before doing this would be a fix closer to the existing logic.
|
The issue in #1489 was that the global invariant for the blob was still
bot
, making themeet
deadcode.TODO:
mutex-meet-atomic
privatization still unsoundmutex-meet-atomic
(It seems weird that no handling of these cases is necessary inget_mutex_global_g_with_mutex_inits_atomic
CC: @sim642)Closes #1489