Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context_to_yojson in messages #1365

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Add context_to_yojson in messages #1365

merged 2 commits into from
Feb 19, 2024

Conversation

karoliineh
Copy link
Member

so that the big context objects would not crowd the JSON and cause java.lang.OutOfMemoryError: Java heap space

@karoliineh karoliineh self-assigned this Feb 15, 2024
@karoliineh karoliineh mentioned this pull request Feb 15, 2024
Merged
@sim642 sim642 added this to the v2.4.0 milestone Feb 15, 2024
sim642
sim642 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@sim642 sim642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this isn't enough to fix the GobPie memory error, it brings JSON messages output closer to the printed one, allowing GobPie to match it.

@karoliineh karoliineh merged commit a35b129 into master Feb 19, 2024
17 checks passed
@karoliineh karoliineh deleted the contexts-in-server-requests branch February 19, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sim642 sim642 sim642 approved these changes

Assignees

@karoliineh karoliineh

Labels
usability
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@karoliineh @sim642