Remove redundant array initializations

goblint · Aug 21, 2023 · fc39dbe · fc39dbe
1 parent 6ffc702
commit fc39dbe
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/api/messages/GoblintMessagesResult.java b/src/main/java/api/messages/GoblintMessagesResult.java
@@ -72,7 +72,7 @@ public List<AnalysisResult> convert(List<Tag> tags, String severity, boolean exp
             GoblintPosition pos = getLocation(loc);
             String msg = joinTags(tags) + " " + text;
             GoblintMessagesAnalysisResult result = new GoblintMessagesAnalysisResult(pos, msg, severity);
-            return new ArrayList<>(List.of(result));
+            return List.of(result);
         }
     }
 
@@ -102,7 +102,7 @@ public List<AnalysisResult> convertGroupExplode(List<Tag> tags, String severity)
             List<GoblintMessagesAnalysisResult> resultsWithoutRelated =
                     pieces.stream().map(piece -> new GoblintMessagesAnalysisResult(getLocation(piece.loc), groupText, piece.text, severity)).toList();
             // Add related warnings to all the pieces in the group
-            List<GoblintMessagesAnalysisResult> resultsWithRelated = new ArrayList<>();
+            List<AnalysisResult> resultsWithRelated = new ArrayList<>();
             for (GoblintMessagesAnalysisResult result : resultsWithoutRelated) {
                 resultsWithRelated.add(
                         new GoblintMessagesAnalysisResult(
@@ -114,7 +114,7 @@ public List<AnalysisResult> convertGroupExplode(List<Tag> tags, String severity)
                                         .map(res -> Pair.make(res.position(), res.text()))
                                         .toList()));
             }
-            return new ArrayList<>(resultsWithRelated);
+            return resultsWithRelated;
         }
 
         public List<AnalysisResult> convertGroup(List<Tag> tags, String severity) {
@@ -132,7 +132,7 @@ public List<AnalysisResult> convertGroup(List<Tag> tags, String severity) {
                             .orElse(getLocation(group_loc));
             GoblintMessagesAnalysisResult result =
                     new GoblintMessagesAnalysisResult(pos, joinTags(tags) + " " + group_text, severity, relatedFromPieces);
-            return new ArrayList<>(List.of(result));
+            return List.of(result);
         }
     }