Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NOBIDS) do not ratelimit api-docs and internal api per default #2852

Merged
merged 2 commits into from
Mar 13, 2024
Merged

(NOBIDS) do not ratelimit api-docs and internal api per default #2852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64772c6
(NOBIDS) do not ratelimit api-docs and internal api per default
guybrush Mar 13, 2024
597df05
(NOBIDS) fix misc command
guybrush Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions cmd/misc/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,15 @@ func disableUserPerEmail() error {
if opts.Email == "" {
return errors.New("no email specified")
}

if utils.Config.Frontend.SessionSecret == "" {
return fmt.Errorf("session secret is empty, please provide a secure random string")
}

logrus.Infof("initializing session store: %v", utils.Config.RedisSessionStoreEndpoint)

utils.InitSessionStore(utils.Config.Frontend.SessionSecret)

user := struct {
ID uint64 `db:"id"`
Email string `db:"email"`
Expand Down
2 changes: 1 addition & 1 deletion ratelimit/ratelimit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func (r *responseWriterDelegator) Status() int {
}

var DefaultRequestFilter = func(req *http.Request) bool {
if req.URL == nil || !strings.HasPrefix(req.URL.Path, "/api") {
if req.URL == nil || !strings.HasPrefix(req.URL.Path, "/api") || strings.HasPrefix(req.URL.Path, "/api/i/") || strings.HasPrefix(req.URL.Path, "/api/v1/docs/") || strings.HasPrefix(req.URL.Path, "/api/v2/docs/") {
return false
}
return true
Expand Down
Loading