(BIDS-2535) added default methods based on contract state #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisei24
requested changes
Feb 6, 2024
Eisei24
approved these changes
Feb 6, 2024
Comment on lines
+4593
to
+4595
| return "Constructor" | ||
| case types.CONTRACT_DESTRUCTION: | ||
| return "Destruction" |
There was a problem hiding this comment.
nitpick: Constructor and Destruction are not the same type of word.
If we want to leave it like that it is also fine.
There was a problem hiding this comment.
I see what you mean, but I think this is okay because developers can decide how a smart contract is constructed, while that's not possible for destruction. I chose that wording to highlight that difference, but it's not a very strong opinion either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.