(Bids 2636) show 0 value internal transactions

[remoterami]

based on #2784

copilot:summary

[Eisei24]

Please have a look at my comments.

There is also this issue:

1. Go to the Internal Transactions tab of a tx that has itx
2. Activate Advanced
   You can see all itx
3. Refresh the page
   => Advanced is still active but you can only see the itx as if it wasn't.
   To see all of them again you need to deactivate Advanced and activate it again.

[Eisei24]

issue: This doesn't make sense to me. What are you trying to do here?
If you now e.g. call this method with:

• valIf: 100.12345
• digitsAfterComma: 10

you would get "100.12345.0000"

or with

• digitsAfterComma: 2

a "100.12." (with a correct tooltip)

Didn't it just work beforehand?

[remoterami]

Not quite, seems like I came across an edge case which isn't handled correctly. Call the method with

• valIf: 100.00001234
• digitsAfterComma: 4

result:

• 10000000

When the number has higher precision than digitsAfterComma, Truncate cuts away all decimal places. We're still adding the missingZeros though, so we'll massively inflate the result 😅

My fix was also wrong of course, thanks for pointing it out; I've adjusted it.

[Eisei24]

I see, good find.
Seems to work for every case now.

[Eisei24]

question: Unlike Etherscan the advanced-itx-switch is visible and works in both the Overview and Internal Transactions tabs.
When clicked in the Overview tab you only see the number in the Internal Transactions tab change.

Should this be how it works?

[remoterami]

Ah no, this was not intended. I assume you're using firefox, because on chrome it works for me; I adopted the same fix we're using for the tabBarSwitcher, this should fix it. The list of internal transactions in the overview tab should only show non-advanced subcalls at all times.

[Eisei24]

Yes, I am normally using Firefox.
It looks fixed for both Firefox and Chrome now.

[Eisei24]

lgtm

When refreshing the page the Advanced switch now resets back to "Off".

[Eisei24]

lgtm, only a merge should have happened since the last approved review.