Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NOBIDS) Fix mainCurrencyPrices undefined error #2751

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

recy21
Copy link
Collaborator

@recy21 recy21 commented Dec 4, 2023

🤖[deprecated] Generated by Copilot at a534196

This pull request adds the chain ID to the backend and frontend of the eth2-beaconchain-explorer website, to support different networks and improve the ETH price display. It modifies the services/services.go, static/js/banner.js, and types/templates.go files.

@recy21 recy21 requested a review from D13ce December 4, 2023 20:12
static/js/banner.js Outdated Show resolved Hide resolved
static/js/banner.js Outdated Show resolved Hide resolved
Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@recy21 recy21 merged commit 72320cd into master Dec 6, 2023
3 checks passed
@recy21 recy21 deleted the NOBIDS/FixMainCurrencyPricesUndefined branch December 6, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants