Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BIDS-2670) batch machine metric inserts #2686

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

peterbitfly
Copy link
Collaborator

@peterbitfly peterbitfly commented Nov 12, 2023

🤖 Generated by Copilot at 3b8030f

This pull request improves the Bigtable integration for storing machine metrics. It introduces a new type BulkMutation to represent batched mutations, and implements a buffering and batching mechanism in db/bigtable.go using a channel and a goroutine.

@peterbitfly peterbitfly requested a review from manuelsc November 12, 2023 17:49
Copy link
Collaborator

@manuelsc manuelsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no issues with the core logic. Only minor nitpicks but nothing that would be a show stopper in case we need this urgently.

db/bigtable.go Outdated Show resolved Hide resolved
db/bigtable.go Show resolved Hide resolved
db/bigtable.go Show resolved Hide resolved
@peterbitfly peterbitfly merged commit 5fea7f9 into master Nov 14, 2023
3 checks passed
@D13ce D13ce deleted the BIDS-2670/batch_machine_metrics_writes branch November 21, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants