Bids 2530/missing block0 #2684
Merged
Bids 2530/missing block0 #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D13ce
commented
Nov 9, 2023
LuccaBitfly
requested changes
Nov 20, 2023
|
Alright, @LuccaBitfly, I believe I have addressed everything. Many thanks for the in-depth review, you've provided valuable feedback 👍 |
LuccaBitfly
requested changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the explorer to show block 0 properly. It should work for both scenarios:
This includes showing block 0 on the blocks page.
Both
indexMissingBlocksandIndexOldEth1Blocksnow work for block 0 and when called for a single block. BothGetFullBlocksDescendingandGetBlocksDescendinghave also been made more error proof.Functions in the misc tool now are also not exported anymore.
Furthermore, it includes smaller bugfixes of bugs that were found while I was working on this: