-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong sync committee participation association #2682
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuccaBitfly
requested changes
Nov 21, 2023
LuccaBitfly
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, wasn't aware that the sync reexport tools are gone so I didn't look at exportSyncCommitteeValidatorStats
in my first review.
LuccaBitfly
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR restores functionality of the sync committee stats and does not aim to fully support the edge case of a validator being part of the same sync committee twice as this requires a wider refactor of how we handle sync committees on the frontend. Will create a jira task for that special case.
Main culprit of current approach was that the de duplication on statistics exporter level shuffled the sync committee index. Removed de duplication in this level since a validator can be elected into the same sync committee multiple times and kept current frontend handling (which does not handle this case at all atm, but so far this hasn't occurred on mainnet or prater yet.)
Requires a re-export via misc tool, command:
Fun Fact: Sync period 827 is utterly wrong on prater db, every one of the 512 validators has a second entry with a different committee indices. Should be fixed via re-export also.
🤖 Generated by Copilot at b3baa4a
This pull request fixes various bugs and inconsistencies in the sync committee data for validators, both in the exporter and the API handler. It also improves the SQL queries and adds comments to make the code more clear and reliable.