Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holesky Rocket Pool Support #2633

Merged
merged 1 commit into from
Nov 3, 2023

(NOBIDS) rocketpool holesky

14b3923
Select commit
Loading
Failed to load commit list.
Merged

Holesky Rocket Pool Support #2633

(NOBIDS) rocketpool holesky
14b3923
Select commit
Loading
Failed to load commit list.
Deleted GitHub App / Copilot for PRs succeeded Oct 23, 2023 in 2m 21s

Analysis complete

Summary

This pull request adds support for the latest Rocket Pool features and testnet, and improves the web3 storage integration. It updates and cleans up the exporter package and the go.mod file, and fixes some bugs and dependency issues.

Walkthrough

  • Add and update dependencies for web3 storage integration and other libraries (link, link, link, link, link, link, link, link, link, link, link, link)
  • Add a variable to map the block numbers of the Redstone upgrade for different chains in exporter/rocketpool.go (link)
  • Set the network value for the Holesky testnet in initRPConfig function in exporter/rocketpool.go (link)
  • Pass a nil argument to the rocketpool.NewClient function call in DownloadMissingRewardTrees function in exporter/rocketpool.go as a temporary workaround (link)
  • Simplify the logic and avoid hard-coding the block numbers in CalculateLifetimeNodeRewardsAllLegacy function in exporter/rocketpool.go by using the new variable (link, link)

Poem

Sing, O Muse, of the valiant exporter package
That bravely faced the Redstone upgrade and the Holesky testnet
And with skill and cunning, fixed the bugs and flaws
That plagued the reward calculation functions.

Emoji

🚀🛠️🧹

Include these descriptions in your pull request description by including the following marker tags:

  • copilot:all: all the content, in one go
  • copilot:summary: a one paragraph summary of the code changes
  • copilot:walkthrough: a step by step walkthrough of the code changes
  • copilot:poem: a poem about the code changes!
  • copilot:emoji: three emoji that capture the changes

Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here].

Details

Copilot for PRs is a limited technical preview from GitHub Next.

It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.

To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord

Progress:

File Status Duration
Summary & Walkthrough ✅ Finished 138.8 seconds
exporter/rocketpool.go ✅ Finished 125.7 seconds
go.mod ✅ Finished 126.7 seconds