Holesky Rocket Pool Support #2633
Analysis complete
Summary
This pull request adds support for the latest Rocket Pool features and testnet, and improves the web3 storage integration. It updates and cleans up the exporter
package and the go.mod
file, and fixes some bugs and dependency issues.
Walkthrough
- Add and update dependencies for web3 storage integration and other libraries (link, link, link, link, link, link, link, link, link, link, link, link)
- Add a variable to map the block numbers of the Redstone upgrade for different chains in
exporter/rocketpool.go
(link) - Set the network value for the Holesky testnet in
initRPConfig
function inexporter/rocketpool.go
(link) - Pass a
nil
argument to therocketpool.NewClient
function call inDownloadMissingRewardTrees
function inexporter/rocketpool.go
as a temporary workaround (link) - Simplify the logic and avoid hard-coding the block numbers in
CalculateLifetimeNodeRewardsAllLegacy
function inexporter/rocketpool.go
by using the new variable (link, link)
Poem
Sing, O Muse, of the valiant
exporter
package
That bravely faced the Redstone upgrade and the Holesky testnet
And with skill and cunning, fixed the bugs and flaws
That plagued the reward calculation functions.
Emoji
🚀🛠️🧹
Include these descriptions in your pull request description by including the following marker tags:
copilot:all
: all the content, in one gocopilot:summary
: a one paragraph summary of the code changescopilot:walkthrough
: a step by step walkthrough of the code changescopilot:poem
: a poem about the code changes!copilot:emoji
: three emoji that capture the changes
Feedback is welcome. Simply add a comment to this PR of the form /copilot feedback [your comments here]
.
Details
Copilot for PRs is a limited technical preview from GitHub Next.
It's aim is to make it easier to write pull request descriptions by providing automatically generated suggestions based on the code changes.
To find out more go to https://githubnext.com/projects/copilot-for-pull-requests or come and chat with us on Discord
File | Status | Duration |
---|---|---|
Summary & Walkthrough | ✅ Finished | 138.8 seconds |
exporter/rocketpool.go | ✅ Finished | 125.7 seconds |
go.mod | ✅ Finished | 126.7 seconds |