Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BIDS-2591) Improve return value for dashboard effectiveness #2631

Merged
merged 2 commits into from
Oct 24, 2023
Merged

(BIDS-2591) Improve return value for dashboard effectiveness #2631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74b0025
(BIDS-2591) Improve return value for dashboard effectiveness
D13ce Oct 23, 2023
273fd46
(BIDS-2591) Changes based on code review
D13ce Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion handlers/dashboard.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,8 @@ func DashboardDataEffectiveness(w http.ResponseWriter, r *http.Request) {
}

if len(activeValidators) == 0 {
http.Error(w, "Invalid query", http.StatusBadRequest)
// valid 200 response with empty data
w.Write([]byte(`{}`))
return
}

Expand Down
3 changes: 3 additions & 0 deletions static/js/dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,6 +976,9 @@ $(document).ready(function () {
method: "GET",
}).then((res) => {
res.json().then((data) => {
if (Object.keys(data).length === 0) {
return
}
let sum = 0.0
for (let eff of data) {
sum += eff
Expand Down
Loading