Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(BIDS-2529) Add block column to tables on address page #2619

Merged
merged 1 commit into from
Nov 2, 2023
Merged

(BIDS-2529) Add block column to tables on address page #2619

merged 1 commit into from
Nov 2, 2023

Conversation

D13ce
Copy link
Contributor

@D13ce D13ce commented Oct 18, 2023

This PR adds a block column to the tables on the address page, namely to

  • Internal Txs
  • Blob Txs (for Dencun)
  • Erc20 Txs
  • Erc721 Txs
  • Erc1155 Txs

LuccaBitfly
LuccaBitfly requested changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to look fine, but

handlers/eth1Account.go Show resolved Hide resolved
LuccaBitfly
LuccaBitfly approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pls don't hurt me

@D13ce D13ce merged commit d3173f7 into master Nov 2, 2023
3 checks passed
@D13ce D13ce deleted the BIDS-2529/AddBlockNumberToAddressTables branch November 2, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuccaBitfly LuccaBitfly LuccaBitfly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D13ce @LuccaBitfly