Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BIDS-2548) Only allow exact matches for the deposits searches #2606

Merged
merged 6 commits into from
Nov 7, 2023

Conversation

Eisei24
Copy link
Collaborator

@Eisei24 Eisei24 commented Oct 11, 2023

Similar to the withdrawals page the deposits page now only allows exact matches for the search to improve query times.

Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understanded how you choosed to improve the code, but I believe the code readability can to be improved. Their are some comments, please have an look :)

db/db.go Outdated Show resolved Hide resolved
db/db.go Outdated Show resolved Hide resolved
db/db.go Show resolved Hide resolved
db/db.go Outdated Show resolved Hide resolved
utils/utils.go Show resolved Hide resolved
@LuccaBitfly
Copy link
Collaborator

Also: merge conflicts

Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than before, but:

db/db.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@LuccaBitfly LuccaBitfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eisei24 Eisei24 merged commit 205798c into master Nov 7, 2023
3 checks passed
@Eisei24 Eisei24 deleted the BIDS-2548/Only_allow_exact_deposits_search branch November 7, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants